Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Magnetic space group identification #41

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[WIP] Magnetic space group identification #41

wants to merge 11 commits into from

Conversation

lan496
Copy link
Member

@lan496 lan496 commented Dec 27, 2024 •
edited
Loading

This includes a lot of breaking changes

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.75591% with 240 lines in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (a631f87) to head (d3ec3a7).

Files with missing lines Patch % Lines
moyo/src/identify/magnetic_space_group.rs 45.98% 101 Missing ⚠️
moyo/src/base/transformation.rs 32.20% 40 Missing ⚠️
moyo/src/identify/normalizer.rs 0.00% 37 Missing ⚠️
moyo/src/lib.rs 0.00% 33 Missing ⚠️
moyo/src/data/magnetic_space_group.rs 0.00% 21 Missing ⚠️
moyo/src/identify/point_group.rs 95.71% 3 Missing ⚠️
moyo/src/data/setting.rs 75.00% 2 Missing ⚠️
moyo/src/data/hall_symbol.rs 94.73% 1 Missing ⚠️
moyo/src/identify/rotation_type.rs 94.11% 1 Missing ⚠️
moyo/src/search/solve.rs 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   87.83%   84.12%   -3.71%     
==========================================
  Files          38       41       +3     
  Lines        5014     5247     +233     
==========================================
+ Hits         4404     4414      +10     
- Misses        610      833     +223

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan496 lan496 added the breaking-changes Incompatible with patch release label Jan 11, 2025
@lan496 lan496 mentioned this pull request Jan 11, 2025
Open
4 tasks
@lan496 lan496 changed the title [WIP] Magnetic space group support [WIP] Magnetic space group identification Jan 11, 2025
@lan496 lan496 force-pushed the msg branch 3 times, most recently from 9ff63ad to 746daef Compare January 11, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-changes Incompatible with patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lan496 @codecov-commenter